Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): InputRange refactor (use InputNumber inside) #1583

Merged
merged 7 commits into from
Apr 11, 2022

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Apr 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this Apr 1, 2022
@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 1, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Visit the preview URL for this PR (updated for commit bd4cb2e):

https://taiga-ui--pr1583-input-range-refactor-f4glp0aj.web.app

(expires Tue, 12 Apr 2022 11:14:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nsbarsukov nsbarsukov force-pushed the input-range-refactor branch 11 times, most recently from baa6148 to a54ad2b Compare April 6, 2022 15:08
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1583 (535b69c) into main (7a0db9d) will increase coverage by 0.99%.
The diff coverage is 72.85%.

❗ Current head 535b69c differs from pull request most recent head bd4cb2e. Consider uploading reports for the commit bd4cb2e to get more accurate results

@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
+ Coverage   62.00%   62.99%   +0.99%     
==========================================
  Files         694      912     +218     
  Lines        8485     9974    +1489     
  Branches     1657     1916     +259     
==========================================
+ Hits         5261     6283    +1022     
- Misses       2817     3250     +433     
- Partials      407      441      +34     
Flag Coverage Δ
addon-charts 74.69% <ø> (ø)
addon-doc 26.15% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 69.52% <ø> (?)
core 67.46% <ø> (ø)
kit 62.60% <72.85%> (-0.35%) ⬇️
summary 62.99% <72.85%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/abstract/input-slider.ts 75.75% <ø> (-6.07%) ⬇️
...s/kit/components/input-range/input-range.module.ts 100.00% <ø> (ø)
.../components/input-slider/input-slider.component.ts 80.32% <ø> (-0.63%) ⬇️
...it/components/input-range/input-range.component.ts 75.30% <72.85%> (-4.89%) ⬇️
projects/kit/utils/miscellaneous/get-precision.ts 0.00% <0.00%> (-100.00%) ⬇️
projects/kit/components/tabs/tab/tab.component.ts 81.25% <0.00%> (-1.11%) ⬇️
...ts/tabs/tabs-with-more/tabs-with-more.component.ts 11.42% <0.00%> (-1.08%) ⬇️
projects/kit/components/avatar/avatar.component.ts 95.00% <0.00%> (-0.24%) ⬇️
projects/kit/tokens/mobile-aware.ts 100.00% <0.00%> (ø)
... and 223 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b55ce3...bd4cb2e. Read the comment docs.

@nsbarsukov nsbarsukov force-pushed the input-range-refactor branch 7 times, most recently from 17064a2 to b7795f7 Compare April 7, 2022 12:28
@nsbarsukov nsbarsukov changed the title [WIP] feat(kit): InputRange refactor (use InputNumber inside) feat(kit): InputRange refactor (use InputNumber inside) Apr 11, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review April 11, 2022 11:52
@nsbarsukov nsbarsukov merged commit fc0f27a into main Apr 11, 2022
@nsbarsukov nsbarsukov deleted the input-range-refactor branch April 11, 2022 13:00
@well-done-bot
Copy link

well-done-bot bot commented Apr 11, 2022

'Well done'

@nsbarsukov nsbarsukov linked an issue Apr 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🛠 - Sliders
4 participants