feat(addon-charts): LineChart add index to hint context
#1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirpotekhin
requested review from
waterplea,
MarsiBarsi and
nsbarsukov
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 63.42% 62.28% -1.14%
==========================================
Files 909 693 -216
Lines 9939 8419 -1520
Branches 1920 1650 -270
==========================================
- Hits 6304 5244 -1060
+ Misses 3193 2768 -425
+ Partials 442 407 -35
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vladimirpotekhin
changed the title
LineChart add index to hint context
|
Visit the preview URL for this PR (updated for commit d253985): https://taiga-ui--pr1580-linechart-context-sswtz7dk.web.app (expires Sat, 02 Apr 2022 12:22:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
splincode
approved these changes
Apr 1, 2022
nsbarsukov
reviewed
Apr 1, 2022
projects/addon-charts/components/line-chart/line-chart-hint.directive.ts
Outdated
Show resolved
Hide resolved
nsbarsukov
approved these changes
Apr 1, 2022
vladimirpotekhin
force-pushed
the
linechart-context
branch
from
6afcb90
to
d253985
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1579
What is the new behavior?
index added to context
Does this PR introduce a breaking change?