Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR's description characters limit won't work #723

Closed
wooch82 opened this issue Jul 31, 2023 · 7 comments
Closed

PR's description characters limit won't work #723

wooch82 opened this issue Jul 31, 2023 · 7 comments

Comments

@wooch82
Copy link

wooch82 commented Jul 31, 2023

I have an error during PR creation with the latest version:

==============================================================================
Task         : Dependabot
Description  : Automatically update dependencies and vulnerabilities in your code
Version      : 1.20.526
Author       : Tingle Software
Help         : For help please visit https://github.com/tinglesoftware/dependabot-azure-devops
==============================================================================
/usr/bin/docker run --rm -i -e DEPENDABOT_PACKAGE_MANAGER=npm -e ghcr.io/tinglesoftware/dependabot-updater-npm:0.20
Updating @rive-app/canvas from 1.2.1 to 2.0.0
Submitting @rive-app/canvas pull request for creation.
============
Failed! PR already exists or an error has occurred.
bin/update-script.rb:857:in `block in <main>': Pull Request creation failed with status 400. Message: Invalid argument value.\r (StandardError)
Parameter name: A description for a pull request must not be longer than 4000 characters.
	from bin/update-script.rb:563:in `each'
	from bin/update-script.rb:563:in `<main>'
##[error]The process '/usr/bin/docker' failed with exit code 1
@hbendev hbendev mentioned this issue Jul 31, 2023
@hbendev
Copy link

hbendev commented Jul 31, 2023

By the way, adding the ability to use the commit's description optionally, instead of this long summary would solve this and future cases of this issue. Related ticket: #579

image

@mburumaxwell
Copy link
Contributor

This is definitely a regression from dependabot/dependabot-core#7487

Hopefully, there is a fix soon

@mburumaxwell
Copy link
Contributor

This is fixed in #724.
Release notes: https://github.com/tinglesoftware/dependabot-azure-devops/releases/tag/1.20.1

@wooch82 , please close if it works for you.

@hbendev
As mentioned in #579, the change proposed is not only major but requires a lot of time. It is most likely easier for Microsoft to increase the limit, but you can also have a go at it.

@wooch82
Copy link
Author

wooch82 commented Aug 1, 2023

Now it works, thank you.
But you just cut the descriptions out, maybe it's better at least give a link to release's notes.

@wooch82 wooch82 closed this as completed Aug 1, 2023
@mburumaxwell
Copy link
Contributor

@wooch82

The truncation in dependabot has always worked by removing the excess characters and the adding a Description has been truncated" at the end. If you haven't seen that let me know.

Luckily I have noticed the releases and change log are added at the top, when available. Also the truncation happens to be a bother when there either many commits, long release notes, or there are many versions from the current to the one being updated to.

@wooch82
Copy link
Author

wooch82 commented Aug 1, 2023

@wooch82

The truncation in dependabot has always worked by removing the excess characters and the adding a Description has been truncated" at the end. If you haven't seen that let me know.

Luckily I have noticed the releases and change log are added at the top, when available. Also the truncation happens to be a bother when there either many commits, long release notes, or there are many versions from the current to the one being updated to.

Ouch, my bad, it was a package from private registry without description. Public registry works well!

@mburumaxwell
Copy link
Contributor

Good to know.
Private feeds with repositories in Azure DevOps should also work unless they are not tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants