Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filtered dataset when no filters remain #194

Closed
timwis opened this issue Mar 15, 2017 · 1 comment
Closed

Remove filtered dataset when no filters remain #194

timwis opened this issue Mar 15, 2017 · 1 comment
Labels
v2-old A previous attempt at v2 using chart.js and plottable

Comments

@timwis
Copy link
Owner

timwis commented Mar 15, 2017

Currently, it still puts the filtered dataset on top of the totals dataset; it just happens to have the same value, so it's hard to notice.

At the moment, there's a bug in Chart.js (chartjs/Chart.js#3791) preventing us from doing this. But once it's resolved, we can simply check for the presence of filters inside Carto.js's componentWillReceiveProps method.
@timwis timwis added the v2-old A previous attempt at v2 using chart.js and plottable label Mar 15, 2017
@timwis
Copy link
Owner Author

timwis commented Dec 5, 2017

Not relevant with plottable.js

@timwis timwis closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2-old A previous attempt at v2 using chart.js and plottable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timwis