Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is not placed in the center in firefox if requested ratio is bigger than image ratio #82

Closed
juli-p opened this issue Nov 29, 2020 · 1 comment
Assignees
Labels
bug Something isn't working firefox

Comments

@juli-p
Copy link

juli-p commented Nov 29, 2020

Describe the bug
I ran into a problem with the basic clipper component: The selected image is placed incorrectly onto the canvas if a ratio bigger than the ratio of the selected image is set. If e.g. a photo with an aspect ratio of 4:3 is selected and I try to set a fixed ratio for the clipper of 4:1 I can not see the image anymore because it seems to be placed too far to the left (if zoomed out completely you can usally find it again). The problem does not show up if a smaller ratio is selected than the original image has.
I only experienced the problem with firefox but not with chromium so I assume it has to do with browser compatibility.

To Reproduce
Steps to reproduce the behavior:

  1. include a basic clipper component
  2. use firefox 76.0 on fedora
  3. select an image to crop
  4. set the ratio prop > than the image aspect ratio

Expected behavior
The expected behaviour obviously would be that the image position is not related to the selected fixed ratio value as it can be seen in chromium.

Screenshots
vue-clipper bug
(zoomed out to show that image is still there but placed incorrectly)

Desktop (please complete the following information):

  • OS: fedora
  • Browser firefox
  • Version 76.0 64-bit
@juli-p juli-p added the bug Something isn't working label Nov 29, 2020
@timtnleeProject
Copy link
Owner

Hi @juli-p ,
thanks for report this issue.
I have released v3.1.1 to fix this issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox
Projects
None yet
Development

No branches or pull requests

2 participants