Fix for moment not working under browserify #25
Conversation
|
Sorry, I'm not super familiar with browserify. I'll read up on it today, but maybe you know the answer to the question. Will this have to change the way Moment.js loads languages? Currently, Moment.js require()s language files relative to the moment.js source based on keys passed in. Will browserify be able to handle this, or does it require a bigger fix? https://github.com/timrwood/moment/blob/master/moment.js#L332 |
|
Hi Tim, At the moment browserify generates a warning when it sees the language require's and I think it does nothing about it - I'm not worried because I'm not using that functionality. It should be safe to ignore the warning - browserify people can always load the languages manually (if I understand the code). Maybe browserify has a way of letting you tell it about these modules, but I'm not sure. |
Fix for moment not working under browserify
|
Ok, sounds good. If people need browserify and moment.lang, they will have to require the lang files manually using browserify. |
|
This is up on npm. |
Alternative construct moment local to timezone
* feature/2.1.0: (36 commits) 2.1.0 release document that the current time will be used for undefined args with isSame, isBefore, and isAfter no longer document Language#months as an array moment#25 adding note on endof and startof week availability addressing moment#42 fixing format weekday docs added a note in the lang docs about using the minified language files rather than the nodejs specific ones adding cdnjs note switching to rawgithub.com urls instead of raw.github.com urls noting cahnge in moment#month to clamp to the end of the target month creating duration from asp.net string, fixing duration subtract example Building docs Duration add, subtract, as, and get docs Adding ISO string docs Adding docs on AM/PM parsing Adding Lang#ordinal token argument adding missing doc files adding docs for max and min adding month string parsing adding timezone setter docs ...
Small fix to the NodeJS detection to make the module work when run client-side using browserify.
I think the way underscore does its client/server-side check best, but didn't want to make that big a change.