Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unwrap() to something else. #9

Open
fullset opened this issue May 7, 2020 · 0 comments
Open

Replace unwrap() to something else. #9

fullset opened this issue May 7, 2020 · 0 comments

Comments

@fullset
Copy link
Collaborator

fullset commented May 7, 2020

let iso_obj: Value = serde_json::from_str(&iso_data).unwrap();

Hi.
As I see, there are a lot of unwrap() methods all around the code. For example above. These calls will panic in case of Err results of unwrapped operations. If this behaviour isn't intended I suggest to use something like unwrap_or(), ok_or() or something else of option API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant