Integrating SBQ #72
Merged
Integrating SBQ #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need positive distances for the ratio in the prune function. This also requires us to make sure the vectors are normalized since cosine on non-normalized vectors could return a distance less than 1.0, which would result in negative distances.
PQ table creation calculates distance on low-dimensional arrays. This needs to be optimized separately.
instead of on the number of items
We found that when using 3 bits instead of one, with dimensions=768 then we get a better accuracy with the same number of shared buffers read. This isn't true for higher dimensions (e.g. 1538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.