Update cohere client to V2 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I keep API keys in environment variables in a .env file. If I ran `just test-server` from my dev host, the command in build.py was explicitly setting the environment vars in the docker exec command without reading the .env file yielding empty environment vars. build.py does not load a .env file because we don't want build.py to depend on any 3rd party dependencies (just std lib). This change fixes the issue. The test server will load the .env file. No need to set env vars explicitly in the `docker exec` call.
jgpruitt
force-pushed
the
jgpruitt/cohere
branch
from
d911f2c to
9962a69
Compare
Askir
approved these changes
Feb 3, 2025
Comment on lines
+102
to
+103
| response = client.embed(texts=[input_text], model=model, embedding_types=["float"], **args) | ||
| return response.embeddings.float[0] |
There was a problem hiding this comment.
Is there any use case to exposing the embedding types to the end user?
There was a problem hiding this comment.
maybe? I did a brief look to see if any alternate embedding type from cohere would map to an alternate vector type from pgvector, but it wasn't obvious that any did.
JamesGuthrie
reviewed
Feb 4, 2025
| -e VOYAGE_API_KEY=${VOYAGE_API_KEY} \ | ||
| -it -w /pgai/tests/vectorizer pgai-ext fastapi dev server.py | ||
| """ | ||
| cmd = """docker exec -it -w /pgai/tests/vectorizer pgai-ext uv run fastapi dev server.py""" |
There was a problem hiding this comment.
Why did you remove the env-var passing here?
There was a problem hiding this comment.
Explained in the commit message. The test server looks up these env cars in a .env file, but for some reason putting these explicitly on the docker exec command was causing them to be empty. It took precedence over the dot env file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cohere client to 5.13.11 which adds support for the V2 endpoints for embed, chat, and rerank. This introduces breaking changes to the corresponding pgai functions, but unlocks the latest features from cohere.
This PR also adds support for Cohere to text-to-sql. This is feature-flagged, non-production code.