chore: get rid of nested parametrization in vectorizer tests #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askir
force-pushed
the
jascha/ai-413-refactor-vectorizer-tests-to-use-less-fixtures-and
branch
5 times, most recently
from
f9cb895 to
fd3952e
Compare
Askir
commented
Jan 27, 2025
| @@ -2053,7 +2053,6 @@ wheels = [ | |||
|
|
|||
| [[package]] | |||
| name = "pgai" | |||
| version = "0.5.0" | |||
There was a problem hiding this comment.
when i ran uv sync --all-extras this was removed, I didn't do that 😅
There was a problem hiding this comment.
Ya I don't quite get what's going on there. I suspect that different minor versions (0.4 vs 0.5) of uv treat this parameter differently, and some write it in and others remove it.
JamesGuthrie
approved these changes
Jan 27, 2025
| cur.executemany( | ||
| "INSERT INTO blog (id, id2, content) VALUES (%s, %s, %s)", values | ||
| ) | ||
| return table_name | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def ollama_connection_url(): | ||
| def ollama_container_url_or_url(): |
There was a problem hiding this comment.
This confuses me, what about just ollama_url?
There was a problem hiding this comment.
yeh fair, I was just confused why this is a fixture and not a constant 😅 which is why i put the container in there, but tbh fair to encapsulate and hide the details.
smoya
approved these changes
Jan 27, 2025
Askir
force-pushed
the
jascha/ai-413-refactor-vectorizer-tests-to-use-less-fixtures-and
branch
from
fd3952e to
5b44a00
Compare
Askir
deleted the
jascha/ai-413-refactor-vectorizer-tests-to-use-less-fixtures-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the vectorizer test suite to be more easily readable by:
run_vectorizer_workerhelper function standardizing CLI invocationI also want to split the file up, but wondering how and if I should do that separately.