fix: make vectorizer worker robust #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgpruitt
reviewed
Nov 28, 2024
jgpruitt
approved these changes
Nov 28, 2024
JamesGuthrie
force-pushed
the
jg/make-vectorizer-robust
branch
from
cd80284 to
4e16374
Compare
These fixes were mostly done in the context of usability with docker compose. Includes the following changes: - Handle being killed with SIGINT or SIGTERM - Handle being unable to connect to the target DB - Handle arbitrary failures in the core of vectorizer worker - Add `--exit-on-error` parameter to force vectorizer worker to exit on error. `--once` implies `--exit-on-error`.
JamesGuthrie
force-pushed
the
jg/make-vectorizer-robust
branch
from
4e16374 to
b4377c8
Compare
smoya
reviewed
Dec 2, 2024
projects/pgai/pgai/cli.py
Outdated
| ) | ||
| sys.exit(1) | ||
| else: | ||
| log.warn( |
There was a problem hiding this comment.
good question. "upgraded" to error.
JamesGuthrie
force-pushed
the
jg/make-vectorizer-robust
branch
from
af0cd66 to
75b51cd
Compare
JamesGuthrie
force-pushed
the
jg/make-vectorizer-robust
branch
from
75b51cd to
a76a56f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes were mostly done in the context of usability with docker compose. Includes the following changes:
--exit-on-errorparameter to force vectorizer worker to exit on error.--onceimplies--exit-on-error.