Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POP-7487] Add materialize adapter for dbt 1.0+ #3

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Nov 16, 2023

PR adds the materialize adapter as another thing we support for our dbt builds. dbt-materialize is unique in that it requires dbt-postgres to also be installed, and so that necessitated altering how build_requirements.txt worked so that I could have a way to specify "extra" requirements for certain adapters. While I initially had a way to do this in the original bash script, I figured this was getting a bit too "hairy" in terms of complex bash scripting and that it'd be hard to maintain in the future, that I also went ahead and rewrote the script to python. It ended up a bit longer, but it's far cleaner and I think easier to edit for other people, especially the lines determining what dependencies to include or not.

Note, while dbt-materialize has versions available for 0.20.0 and 0.21.0, they used exact version matching against dbt-postgres (so dbt-materialize==0.21.0 required dbt-postgres==0.21.0), which would necessitate downgrading the version of dbt-postgres@^0.21.1 we use. Given that I'm not sure the ramifications of that, and that these versions are years old and very much EOL, I figured fine to not support them unless someone explicitly asks and we can revisit then. We already also have precedent of some adapters only support 1.0+ (athena).

Copy link

linear bot commented Nov 16, 2023

POP-7487 Add materialize support for dbt

What

Add support for materialize connections in dbt using the dbt-materialize adapter. This would allow materialize folks to recommend us as a cloud based editor for dbt + materialize, given that dbt Cloud does not support it.

Why

  1. Strengthen relationship with materialize
  2. Have feature that they do not have with dbt Cloud

@MasterOdin MasterOdin merged commit dfc552f into main Nov 16, 2023
2 checks passed
@MasterOdin MasterOdin deleted the matt/pop-7487-add-materialize-support-for-dbt branch November 16, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant