From 38c6f4c201ebdd8a6ebea63455e375a7571e0278 Mon Sep 17 00:00:00 2001 From: Andrew Hammond <445764+ahammond@users.noreply.github.com> Date: Thu, 9 May 2024 15:39:25 -0700 Subject: [PATCH] feat: allow pnpm [CLK-252116] --- src/clickup-cdk.ts | 6 +----- test/clickup-cdk.test.ts | 11 +---------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/src/clickup-cdk.ts b/src/clickup-cdk.ts index 20cf831a..ccc1a2ea 100644 --- a/src/clickup-cdk.ts +++ b/src/clickup-cdk.ts @@ -1,4 +1,4 @@ -import { awscdk, Component, javascript, JsonPatch, SampleDir, SampleReadme } from 'projen'; +import { awscdk, Component, JsonPatch, SampleDir, SampleReadme } from 'projen'; import * as semver from 'semver'; import merge from 'ts-deepmerge'; @@ -204,10 +204,6 @@ export module clickupCdk { readonly workflowNodeVersion?: string; constructor(options: ClickUpCdkTypeScriptAppOptions) { - if (options.packageManager === javascript.NodePackageManager.PNPM) { - throw new Error('pnpm not supported by cdkPipelines: https://staging.clickup.com/t/333/CLK-252116'); - } - // This cdkVersion is actually the minimum version that's compatible. This only affects devDeps. // This really only affects users when they try to deploy directly from their laptop. // When deploying from cdkPipelines, it will use whatever version the library is currently on per yarn.lock. diff --git a/test/clickup-cdk.test.ts b/test/clickup-cdk.test.ts index 2ef1d419..b8efa5e1 100644 --- a/test/clickup-cdk.test.ts +++ b/test/clickup-cdk.test.ts @@ -1,5 +1,5 @@ import path from 'path'; -import { Testing, javascript } from 'projen'; +import { Testing } from 'projen'; import { requiredParams } from './requiredParams'; import { clickupCdk } from '../src'; import { datadogServiceCatalog } from '../src/datadog-service-catalog'; @@ -38,15 +38,6 @@ describe('ClickUpCdkTypeScriptApp', () => { expect(p.datadogEvent).toBeFalsy(); }); - test('pnpm throws', () => { - expect(() => { - new clickupCdk.ClickUpCdkTypeScriptApp({ - ...requiredParams, - packageManager: javascript.NodePackageManager.PNPM, - }); - }).toThrowError(/pnpm not supported by cdkPipelines/); - }); - describe('node20', () => { p = new clickupCdk.ClickUpCdkTypeScriptApp({ ...requiredParams,