Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 2 #4

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Bugfix 2 #4

merged 7 commits into from
Jan 25, 2024

Conversation

mkabza
Copy link
Collaborator

@mkabza mkabza commented Jan 25, 2024

Fix for the issue #2, concerning @lingminhao and @mcortes-lopez

Implemented changes:

  • parsing BAM files has been made more stringent by disallowing secondary alignments, as well as reads that are duplicated or don't pass QC criteria
  • inter-chromosomal alignments are now automatically removed from the analysis
  • added the max_intron_length (default 5e6) argument to the prepare_transcripts function, which should lower FDR in some cases
  • added new assertion to the prepare_transcripts function, which should catch problems with non-unique intron_positions values in input data
  • updated the unit tests to reflect the introduced changes and re-built the vignettes & the manual

@mkabza mkabza merged commit d9e34cb into devel Jan 25, 2024
@mkabza mkabza deleted the bugfix_2 branch January 25, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant