Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed urls without leading protocol #13

Open
tilboerner opened this issue Jul 23, 2013 · 4 comments
Open

feed urls without leading protocol #13

tilboerner opened this issue Jul 23, 2013 · 4 comments
Labels

Comments

@tilboerner
Copy link
Owner

When an incomplete feed URL (without the protocol part) is entered, Laserchicken should add http:// as default. Otherwise, feed duplication won't be recognized and links to feed XML will break.

@tilboerner
Copy link
Owner Author

feed duplication won't be recognized

Same goes for alias URLs with trailing / or www subdomains. Just something to think about.

@XORwell
Copy link
Contributor

XORwell commented Aug 13, 2013

what do you mean with links to feed XML will break

Entered a feed-url without http:// but got no errors.. Can you give some information how to reproduce it?

@tilboerner
Copy link
Owner Author

Sorry, should have been more precise. When you're admin, you have access to the /feeds resource, which lists all known feeds. In that list, there's a link to the actual XML with the (probably misleading) name "(web)". Without a a leading protocol, this link is treated as relative, which is incorrect.

I think the best way to deal with this is to make the URL complete by adding a default protocol as early as possible.

Incomplete URLs already in the database could be changed with the help of a migration, I guess.

@XORwell
Copy link
Contributor

XORwell commented Aug 13, 2013

i decided to fix #10 a bit nicer than before and ended with a class which may also help to fix incomplete urls already in the database https://github.com/XORwell/laserchicken/commit/85a1f09f86afbd8a9bc938355b4f0dfeb6c1c92a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants