From 3c1570e56bbb3b007bf68be808aee7d0704dd2f0 Mon Sep 17 00:00:00 2001 From: Bin Shi Date: Mon, 12 Jun 2023 22:01:46 -0700 Subject: [PATCH] Fix stream Send() and CloseSend() data race issue in tso proxy. Signed-off-by: Bin Shi --- server/grpc_service.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/server/grpc_service.go b/server/grpc_service.go index dcc3e02abf2..7dc3b72ed95 100644 --- a/server/grpc_service.go +++ b/server/grpc_service.go @@ -411,9 +411,6 @@ func (s *GrpcServer) forwardTSO(stream pdpb.PD_TsoServer) error { ) defer func() { s.concurrentTSOProxyStreamings.Add(-1) - if forwardStream != nil { - forwardStream.CloseSend() - } // cancel the forward stream if cancel != nil { cancel() @@ -452,9 +449,6 @@ func (s *GrpcServer) forwardTSO(stream pdpb.PD_TsoServer) error { return errors.WithStack(ErrNotFoundTSOAddr) } if forwardStream == nil || lastForwardedHost != forwardedHost { - if forwardStream != nil { - forwardStream.CloseSend() - } if cancel != nil { cancel() }