Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labelLevelStats may leak when merging regions #8700

Closed
rleungx opened this issue Oct 14, 2024 · 2 comments · Fixed by #8703
Closed

labelLevelStats may leak when merging regions #8700

rleungx opened this issue Oct 14, 2024 · 2 comments · Fixed by #8703

Comments

@rleungx
Copy link
Member

rleungx commented Oct 14, 2024

Bug Report

Consider the following case:

  1. Patrol region has scanned a batch of regions, e.g., a,b,c,d
  2. Before updating label statistics, the merge finished, e.g., merge a and b
  3. PD will remove one of the regions, assumed b, from label statistics because of overlaps during the process of region heartbeat.
  4. Then patrol region update a,b,c,d to label statistics

b will never be deleted again and left in memory until the PD is restarted.

@okJiang
Copy link
Member

okJiang commented Oct 15, 2024

This issue only affects metrics?

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 16, 2024

This issue only affects metrics?

If the cluster has a high frequency of merge regions, this may cause memory growth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants