Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider check the term when update the leader #2657

Closed
nolouch opened this issue Jul 16, 2020 · 2 comments · Fixed by #2667
Closed

Consider check the term when update the leader #2657

nolouch opened this issue Jul 16, 2020 · 2 comments · Fixed by #2667
Labels
difficulty/easy Easy task. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@nolouch
Copy link
Contributor

nolouch commented Jul 16, 2020

Feature Request

Describe your feature request related problem

There are sometimes the PD updates invalid cache information because TiKV reported old heartbeat information, we already consider check the epoch before update the region cache, but the leader changed do not changed the epoch, we need to check the term to prevent the invalid update:

image

Describe alternatives you've considered

  • check the term before updating the region cache to prevent the invalid updates.

Teachability, Documentation, Adoption, Migration Strategy

@nolouch nolouch added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. difficulty/easy Easy task. labels Jul 16, 2020
@nolouch nolouch changed the title Consider check the term when update the leader. Consider check the term when update the leader Jul 16, 2020
@nolouch
Copy link
Contributor Author

nolouch commented Jul 16, 2020

Would you like to try it? @howardlau1999

@howardlau1999
Copy link
Contributor

Would you like to try it? @howardlau1999

Yes, I'll give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/easy Easy task. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants