Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the error handling by removing pkg/errors #2643

Closed
rleungx opened this issue Jul 14, 2020 · 1 comment · Fixed by #2644
Closed

Unify the error handling by removing pkg/errors #2643

rleungx opened this issue Jul 14, 2020 · 1 comment · Fixed by #2644
Labels
status/TODO The issue will be done in the future. type/enhancement The issue or PR belongs to an enhancement.
Milestone
v4.0.6

Comments

@rleungx
Copy link
Member

rleungx commented Jul 14, 2020

Currently, the repo has three kinds of packages to handle errors. See go.mod.

github.com/pingcap/errcode v0.0.0-20180921232412-a1a7271709d9
github.com/pingcap/errors v0.11.5-0.20190809092503-95897b64e011
github.com/pkg/errors v0.9.1

It's better to replace github.com/pkg/errors with github.com/pingcap/errors since they are almost the same except for some fixes and stack support.
@rleungx rleungx added type/enhancement The issue or PR belongs to an enhancement. status/TODO The issue will be done in the future. labels Jul 14, 2020
@rleungx rleungx mentioned this issue Jul 14, 2020
Merged
@rleungx
Copy link
Member Author

rleungx commented Jul 15, 2020

Since we only use github.com/pkg/errors now, close it

@rleungx rleungx closed this as completed Jul 15, 2020
@HunDunDM HunDunDM added this to the v4.0.6 milestone Aug 10, 2020
@HunDunDM HunDunDM reopened this Aug 10, 2020
@ti-srebot ti-srebot mentioned this issue Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/TODO The issue will be done in the future. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging a pull request may close this issue.

*: unify error handling by removing pkg/errors rleungx/pd
2 participants
@HunDunDM @rleungx