makefile: disable flag-parameter check (#2264)

Signed-off-by: disksing <i@disksing.com>

Author: disksing

pkg/btree/btree.go

@@ -670,7 +670,7 @@ const (
 // will force the iterator to include the first item when it equals 'start',
 // thus creating a "greaterOrEqual" or "lessThanEqual" rather than just a
 // "greaterThan" or "lessThan" queries.
-func (n *node) iterate(dir direction, start, stop Item, includeStart bool, hit bool, iter ItemIterator) (bool, bool) { // revive:disable-line:flag-parameter,confusing-results
+func (n *node) iterate(dir direction, start, stop Item, includeStart bool, hit bool, iter ItemIterator) (bool, bool) { // revive:disable-line:confusing-results
 	var ok, found bool
 	var index int
 	switch dir {
@@ -1049,7 +1049,7 @@ func (t *BTree) getRootLength() int {
 //   O(tree size):  when all nodes are owned by another tree, all nodes are
 //       iterated over looking for nodes to add to the freelist, and due to
 //       ownership, none are.
-func (t *BTree) Clear(addNodesToFreelist bool) { // revive:disable-line:flag-parameter
+func (t *BTree) Clear(addNodesToFreelist bool) {
 	if t.root != nil && addNodesToFreelist {
 		t.root.reset(t.cow)
 	}

pkg/cache/two_queue.go

@@ -91,7 +91,6 @@ func (c *TwoQueue) Put(key uint64, value interface{}) {
 	c.recent.Put(key, value)
 }
 
-// revive:disable-next-line:flag-parameter
 func (c *TwoQueue) ensureSpace(ghost bool) {
 	recentLen := c.recent.Len()
 	frequentLen := c.frequent.Len()

pkg/mock/mockhbstream/mockhbstream.go

@@ -79,7 +79,7 @@ type HeartbeatStreams struct {
 }
 
 // NewHeartbeatStreams creates a new HeartbeatStreams.
-func NewHeartbeatStreams(clusterID uint64, noNeedRun bool) *HeartbeatStreams { // revive:disable-line:flag-parameter
+func NewHeartbeatStreams(clusterID uint64, noNeedRun bool) *HeartbeatStreams {
 	ctx, cancel := context.WithCancel(context.Background())
 	hs := &HeartbeatStreams{
 		ctx:       ctx,

revive.toml

@@ -22,7 +22,9 @@ warningCode = 0
 [rule.modifies-parameter]
 [rule.confusing-naming]
 [rule.confusing-results]
-[rule.flag-parameter]
+
+# It generates unnecessary reports
+#[rule.flag-parameter]
 
 # Currently this makes too much noise, but should add it in
 # and perhaps ignore it in a few files

server/cluster/cluster.go

@@ -912,7 +912,7 @@ func (c *RaftCluster) RemoveStore(storeID uint64) error {
 // State transition:
 // Case 1: Up -> Tombstone (if force is true);
 // Case 2: Offline -> Tombstone.
-func (c *RaftCluster) BuryStore(storeID uint64, force bool) error { // revive:disable-line:flag-parameter
+func (c *RaftCluster) BuryStore(storeID uint64, force bool) error {
 	c.Lock()
 	defer c.Unlock()
 

server/config/config.go

@@ -738,7 +738,6 @@ func (c *ScheduleConfig) migrateConfigurationMap() map[string][2]*bool {
 	}
 }
 
-// revive:disable-next-line:flag-parameter
 func (c *ScheduleConfig) parseDeprecatedFlag(meta *configMetaData, name string, old, new bool) (bool, error) {
 	oldName, newName := "disable-"+name, "enable-"+name
 	defineOld, defineNew := meta.IsDefined(oldName), meta.IsDefined(newName)

server/schedule/operator/builder.go

@@ -537,7 +537,7 @@ func (b *Builder) labelMatch(x, y uint64) int {
 	return len(labels)
 }
 
-func b2i(b bool) int { // revive:disable-line:flag-parameter
+func b2i(b bool) int {
 	if b {
 		return 1
 	}