From 01830480f6d8536f7e24d10cf404c1548b85f885 Mon Sep 17 00:00:00 2001 From: Ryan Leung Date: Wed, 9 Aug 2023 17:57:28 +0800 Subject: [PATCH] improve the keep alive worker Signed-off-by: Ryan Leung --- pkg/election/lease.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/election/lease.go b/pkg/election/lease.go index 1e3e66ddcce..441f66a4cbd 100644 --- a/pkg/election/lease.go +++ b/pkg/election/lease.go @@ -174,8 +174,11 @@ func (l *lease) keepAliveWorker(ctx context.Context, interval time.Duration) <-c expire := start.Add(time.Duration(res.TTL) * time.Second) select { case ch <- expire: - case <-ctx1.Done(): + // Here we don't use `ctx1.Done()` because we want to make sure if the keep alive success, we can update the expire time. + case <-ctx.Done(): } + } else { + log.Error("keep alive response ttl is zero", zap.String("purpose", l.Purpose)) } }()