Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install -v not supported on NetBSD #28

Closed
0323pin opened this issue May 31, 2022 · 7 comments · Fixed by #31
Closed

install -v not supported on NetBSD #28

0323pin opened this issue May 31, 2022 · 7 comments · Fixed by #31

Comments

@0323pin
Copy link

0323pin commented May 31, 2022

Hi,

jemalloc-sys is a crate dependency of several rust packages we provide as native NetBSD packages.
Today I came across the first one that has moved from v0.3.2 to v0.5.0+5.3.0, fd, https://github.com/sharkdp/fd

This package used to build successfully with v0.3.2 but now fails since NetBSD install does not support the -v option.
The error while building here.

Any chance you could fix this portability issue and support as many OS's as possible?
Thanks!

@BusyJay
Copy link
Member

BusyJay commented May 31, 2022

Sorry, I don't have NetBSD installation on hand. This seems probably an issue of jemalloc itself as all jemallocator does is make install. Can you verify whether github.com/jemalloc/jemalloc itself can compile on NetBSD?

@0323pin
Copy link
Author

0323pin commented Jun 1, 2022

Sorry, I don't have NetBSD installation on hand.

That's fine, I understand it.

Can you verify whether github.com/jemalloc/jemalloc itself can compile on NetBSD?

jemalloc-5.2.1 is available on our package repository. But, I see it contains a few patches, so this might be the problem, as it will probably not build without those. I need some time to go through the patches and see if they are relevant or not.

@0323pin
Copy link
Author

0323pin commented Jun 1, 2022

@BusyJay jemalloc/jemalloc#2284
Shall we close this now and hope for a new jemalloc release or, shall we keep this open until that's done?

@BusyJay
Copy link
Member

BusyJay commented Jun 1, 2022

Cool, let's keep this open.

@0323pin
Copy link
Author

0323pin commented Jun 7, 2022

@BusyJay jemalloc has been fixed now. Guess we need a release, unless you want to pull from git HEAD.

@BusyJay
Copy link
Member

BusyJay commented Jun 7, 2022

I will wait some time for the new release. Otherwise I will create a patch release in tikv's fork first.

@0323pin
Copy link
Author

0323pin commented Jun 24, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants