Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: moved bunx and dockertestx out of the root modules #79

Merged
merged 7 commits into from
Dec 1, 2024

Conversation

sawadashota
Copy link
Collaborator

@sawadashota sawadashota commented Nov 29, 2024

Moved bunx and dockertestx out of the root modules since they have many dependencies that most users don't need.
Users can install these modules using the following commands:

go get github.com/tier4/x-go/dockertestx
go get github.com/tier4/x-go/bunx

@sawadashota sawadashota force-pushed the divide-modules branch 2 times, most recently from 32e78be to 4a3e769 Compare November 29, 2024 07:23
@sawadashota sawadashota changed the title feat!: independent modules: bunx and dockertestx feat!: moved bunx and dockertestx out of the root modules Nov 29, 2024
@@ -8,9 +8,9 @@ jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: GoogleCloudPlatform/release-please-action@v2
- uses: googleapis/release-please-action@v4
Copy link
Collaborator Author

@sawadashota sawadashota Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GoogleCloudPlatform/release-please-action@v2 is outdated. We now need to create release tags with directory prefixes (e.g., dockertestx/v0.1.7 ). This has been tested in PR #85.

When a new version like v1.0.0 is suggested, we can manually specify the desired next version.
For more details, see: https://github.com/googleapis/release-please?tab=readme-ov-file#how-can-i-fix-release-notes

@sawadashota sawadashota marked this pull request as ready for review November 29, 2024 08:53
Copy link
Contributor

@ropoc ropoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sawadashota sawadashota merged commit 93ad5a5 into main Dec 1, 2024
6 checks passed
@sawadashota sawadashota deleted the divide-modules branch December 1, 2024 23:39
@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants