Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dockertestx): S3 #18

Merged
merged 1 commit into from
May 31, 2021
Merged

feat(dockertestx): S3 #18

merged 1 commit into from
May 31, 2021

Conversation

rxnew
Copy link
Collaborator

@rxnew rxnew commented May 31, 2021

Supports dockertest for S3 using minio/minio.

@rxnew rxnew requested a review from sawadashota May 31, 2021 05:57
sawadashota
sawadashota approved these changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@sawadashota sawadashota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxnew rxnew merged commit 5741787 into main May 31, 2021
@rxnew rxnew deleted the feature/dockertestx-s3 branch May 31, 2021 06:30
This was referenced Nov 29, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawadashota sawadashota sawadashota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxnew @sawadashota