Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could fct_reorder be easier to use for where .desc = TRUE? #362

Closed
davidhodge931 opened this issue May 9, 2024 · 1 comment
Closed

Could fct_reorder be easier to use for where .desc = TRUE? #362

davidhodge931 opened this issue May 9, 2024 · 1 comment

Comments

@davidhodge931
Copy link

davidhodge931 commented May 9, 2024 •
edited
Loading

Maybe this is overkill, but wondering if it would be useful to have a specific function that relates to where .desc = TRUE in fct_reorder.

So either:

  1. keep fct_reorder & add fct_reorder_desc function
  2. deprecate fct_reorder, & add fct_reorder_asc and fct_reorder_desc functions

Could be something for tidy-dev-day?
@davidhodge931 davidhodge931 changed the title Could a fct_reorder_desc shortcut function be created for fct_reorder(..., .desc = TRUE)? Could a fct_reorder descending shortcut function be created for fct_reorder(..., .desc = TRUE)? May 10, 2024
@davidhodge931 davidhodge931 changed the title Could a fct_reorder descending shortcut function be created for fct_reorder(..., .desc = TRUE)? Could fct_reorder be easier to use for where .desc = TRUE? May 10, 2024
@hadley
Copy link
Member

hadley commented Oct 21, 2024

That feels like a very specialised function, so at least for now I'd prefer to keep it as an argument.

@hadley hadley closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @davidhodge931