-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove homegrown deprecation functions #323
Comments
I think this can probably replace lifecycle::deprecate_warn(
when = "0.0.7",
what = I("The global option `yardstick.event_first`"),
with = I("the metric function argument `event_level`"),
details = "The global option is being ignored entirely."
) At this point I hope most people have moved off this global option, so I think we can just stop supporting it in the next minor version of yardstick as mentioned here #173 (comment) |
For the roc-curve one you can probably use the standard lifecycle syntax of Lines 216 to 225 in d56da5e
And for Lines 209 to 217 in 1323a73
Both of those can also use Then you can nuke this file https://github.com/tidymodels/yardstick/blob/main/R/compat-lifecycle.R |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Originally posted by @DavisVaughan in #322 (comment)
The text was updated successfully, but these errors were encountered: