Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: l10n - German translation #1148

Merged
merged 6 commits into from
Jun 21, 2023
Merged

feat: l10n - German translation #1148

merged 6 commits into from
Jun 21, 2023

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jun 11, 2023

Not all strings but a start:

Screenshot_20230611_124732

  • main view and buttons
  • create a new app process

@m1ga m1ga requested a review from ewanharris June 11, 2023 10:49
@ewanharris
Copy link
Collaborator

This is awesome to see @m1ga, is there anything I can do to help this along?

@m1ga
Copy link
Contributor Author

m1ga commented Jun 15, 2023

Thanks!

It would be nice if you could merge it once you've look at the code - no release yet. Then we can improve the translation (add more strings) and other people can start other language files. We have a spanish version waiting already :)

This would get everyone at the same base level and we can just continue to work on the language files itself

@jordanbisato
Copy link

I am doing the pt-BR too.

@ewanharris
Copy link
Collaborator

@m1ga would you mind if I potentially change the structure of the package.nls.json file so that we can extract title and descriptions for commands? I think I should be able to adapt the existing readme generation script to generate this file directly from the package.json

@m1ga
Copy link
Contributor Author

m1ga commented Jun 20, 2023

not at all! Feel free to change it. I can add my translation to it if you create a different PR.

@ewanharris
Copy link
Collaborator

I just pushed a commit that runs this script and generates all valid strings and updated the existing German translations.

I'll look to see if I can add this to the repo as a build step to help reduce the friction in adding these (i.e. edit the package.json as normal, then run the script to generate).

This PR looks good to me from a quick test so I'm happy to merge if you are @m1ga!

@m1ga
Copy link
Contributor Author

m1ga commented Jun 20, 2023

This is awesome! that helps to translate all other strings later on 👍
Looking good! Many people want to help translate it into their language already 😄

@ewanharris ewanharris merged commit 42da08d into master Jun 21, 2023
@ewanharris ewanharris deleted the l10n branch June 21, 2023 17:28
github-actions bot pushed a commit that referenced this pull request Aug 20, 2023
# [1.2.0](v1.1.0...v1.2.0) (2023-08-20)

### Bug Fixes

* more de strings ([#1159](#1159)) ([4aace01](4aace01))
* **providers:** always generate completion data after info load ([#1171](#1171)) ([4688458](4688458)), closes [#1165](#1165)

### Features

* **explorer/build:** allow building modules to specific targets ([#1000](#1000)) ([4af0313](4af0313))
* support building for macos ([#1130](#1130)) ([5a269a8](5a269a8)), closes [#1129](#1129)
* support German language ([#1148](#1148)) ([42da08d](42da08d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants