Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: OptionBar parity #13323

Closed
1 task done
caspahouzer opened this issue Mar 23, 2022 · 4 comments · Fixed by #13324
Closed
1 task done

Android: OptionBar parity #13323

caspahouzer opened this issue Mar 23, 2022 · 4 comments · Fixed by #13324
Labels
android feature needs triage This issue hasn't been reviewed by maintainers parity 👯‍♀️

Comments

@caspahouzer
Copy link
Contributor

I have searched and made sure there are no existing issues for the issue I am filing

  • I have searched the existing issues

Description

When I select a label from an OptionBar on iOS and programmatically set the index to -1, the OptionBar is deselected completely.

On Android, the OptionBar label stays selected

Solution

The OptionBar should be in the unselected state like iOS.

Markers from @m1ga
default Value and checkOption

Alternatives

No response

Platforms

Android & iOS

@caspahouzer caspahouzer added android feature parity 👯‍♀️ needs triage This issue hasn't been reviewed by maintainers labels Mar 23, 2022
@hansemannn
Copy link
Collaborator

The default should remain as-is (to select the first element - I think that's also the case for iOS?), but the checkOption method could indeed be extended pretty easily. @caspahouzer Can you try that yourself?

@caspahouzer
Copy link
Contributor Author

No, I have no idea of Java development. But I try it locally. If I really get it working, I make a PR and you comment how creepy I did it 😄

@caspahouzer
Copy link
Contributor Author

@m1ga
Copy link
Contributor

m1ga commented Mar 23, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android feature needs triage This issue hasn't been reviewed by maintainers parity 👯‍♀️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants