From 2cca3e342fbe052d9cc15e6605c0d7b7c6df5d85 Mon Sep 17 00:00:00 2001 From: Ewan Harris Date: Tue, 9 Feb 2021 14:23:48 +0000 Subject: [PATCH 1/3] feat!: set minimum node version to 12.13.0 Closes TIMOB-28343 --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 072e0f81ca9..4d4fc4ba639 100644 --- a/package.json +++ b/package.json @@ -165,10 +165,10 @@ "url": "git://github.com/appcelerator/titanium_mobile.git" }, "vendorDependencies": { - "node": "10.x || 12.x" + "node": "12.x || 14.x" }, "engines": { - "node": ">=10.13" + "node": ">=12.13.0" }, "nyc": { "exclude": [ From 41916295bb09163cfd4c10f4102b88fb85e00dd5 Mon Sep 17 00:00:00 2001 From: Ewan Harris Date: Tue, 9 Feb 2021 14:25:11 +0000 Subject: [PATCH 2/3] ci: use node 12.18.0 --- Jenkinsfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Jenkinsfile b/Jenkinsfile index b6b54b82b69..e0b0e5c1e5c 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -33,7 +33,7 @@ def testOnAndroidDevices = false // testOnDevices // FIXME: Our android device i def testOnIOSDevices = testOnDevices // Variables we can change -def nodeVersion = '10.17.0' // NOTE that changing this requires we set up the desired version on jenkins master first! +def nodeVersion = '12.18.0' // NOTE that changing this requires we set up the desired version on jenkins master first! def npmVersion = 'latest' // We can change this without any changes to Jenkins. 5.7.1 is minimum to use 'npm ci' // Variables which we assign and share between nodes From 83a1449d5c36adbcc12a81d9eac38e91ac435e40 Mon Sep 17 00:00:00 2001 From: Ewan Harris Date: Tue, 9 Feb 2021 16:06:03 +0000 Subject: [PATCH 3/3] fix: declare i18n function before its usage --- iphone/cli/hooks/run.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/iphone/cli/hooks/run.js b/iphone/cli/hooks/run.js index 4f637550c73..44eac999326 100644 --- a/iphone/cli/hooks/run.js +++ b/iphone/cli/hooks/run.js @@ -17,15 +17,16 @@ exports.init = function (logger, config, cli) { return finished(); } + const i18n = require('node-appc').i18n(__dirname); + const __ = i18n.__; + const __n = i18n.__n; + if (cli.argv['build-only']) { logger.info(__('Performed build only, skipping running of the application')); return finished(); } const ioslib = require('ioslib'); - const i18n = require('node-appc').i18n(__dirname); - const __ = i18n.__; - const __n = i18n.__n; const path = require('path'); const fs = require('fs-extra'); // eslint-disable-next-line security/detect-child-process