Skip to content

Commit 4f8bb59

Browse files
committed
Merge branch 'release/1.2.0'
2 parents 76520b0 + 0e46c52 commit 4f8bb59

File tree

8 files changed

+48
-25
lines changed

8 files changed

+48
-25
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Change Log
22

3+
## Version 1.2.0 *(July 2nd 2018)*
4+
5+
* Parsing WayPoint description.
6+
37
## Version 1.1.2 *(June 26th 2018)*
48

59
* Fix to prevent endless loop in case of malformed GPX track (thanks to D. Elliot!)

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ Download
1212
Grab via Gradle:
1313

1414
```groovy
15-
api 'io.ticofab.androidgpxparser:parser:1.1.2'
16-
// compile 'io.ticofab.androidgpxparser:parser:1.1.2' - for gradle plugin < 3.0.0
15+
api 'io.ticofab.androidgpxparser:parser:1.2.0'
16+
// compile 'io.ticofab.androidgpxparser:parser:1.2.0' - for gradle plugin < 3.0.0
1717
```
1818

1919
Dependencies

app/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ android {
99
minSdkVersion 14
1010
targetSdkVersion 27
1111
versionCode 2
12-
versionName "1.1.2"
12+
versionName "1.2.0"
1313
}
1414
buildTypes {
1515
release {

parser/build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ ext {
1313
siteUrl = 'https://github.com/ticofab/android-gpx-parser'
1414
gitUrl = 'https://github.com/ticofab/android-gpx-parser.git'
1515

16-
libraryVersion = '1.1.2'
16+
libraryVersion = '1.2.0'
1717

1818
developerId = 'ticofab'
1919
developerName = 'Fabio Tiriticco'
@@ -31,8 +31,8 @@ android {
3131
defaultConfig {
3232
minSdkVersion 14
3333
targetSdkVersion 27
34-
versionCode 6
35-
versionName "1.1.2"
34+
versionCode 7
35+
versionName "1.2.0"
3636
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3737
}
3838
buildTypes {
@@ -46,7 +46,7 @@ android {
4646
dependencies {
4747
// JodaTime for Android
4848
// https://github.com/dlew/joda-time-android
49-
implementation 'net.danlew:android.joda:2.9.9.2'
49+
implementation 'net.danlew:android.joda:2.9.9.4'
5050

5151
androidTestImplementation 'junit:junit:4.12'
5252
androidTestImplementation 'com.android.support:support-annotations:27.1.1'

parser/src/androidTest/java/io/ticofab/androidgpxparser/parser/GPXParserTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ public void testGarminBaseCampExport() throws IOException, XmlPullParserExceptio
4747
assertEquals(3, gpx.getWayPoints().size());
4848
assertEquals(1, gpx.getRoutes().size());
4949
assertEquals(7, gpx.getRoutes().get(0).getRoutePoints().size());
50+
assertEquals(" A92", gpx.getWayPoints().get(0).getDesc());
51+
assertEquals("Erding Ab", gpx.getWayPoints().get(2).getDesc());
5052
}
5153

5254
@Test(expected = XmlPullParserException.class)

parser/src/main/java/io/ticofab/androidgpxparser/parser/GPXParser.java

+3
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,9 @@ private Point readPoint(Point.Builder builder, XmlPullParser parser, String tagN
264264
case TAG_NAME:
265265
builder.setName(readName(parser));
266266
break;
267+
case TAG_DESC:
268+
builder.setDesc(readDesc(parser));
269+
break;
267270
case TAG_ELEVATION:
268271
builder.setElevation(readElevation(parser));
269272
break;

parser/src/main/java/io/ticofab/androidgpxparser/parser/domain/Point.java

+18-4
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,22 @@
44

55
/**
66
* A point containing a location, time and name.
7-
*
87
*/
98
public abstract class Point {
109
private final Double mLatitude;
1110
private final Double mLongitude;
1211
private final Double mElevation;
1312
private final DateTime mTime;
14-
private String mName;
13+
private final String mName;
14+
private final String mDesc;
1515

1616
Point(Builder builder) {
1717
mLatitude = builder.mLatitude;
1818
mLongitude = builder.mLongitude;
1919
mElevation = builder.mElevation;
2020
mTime = builder.mTime;
2121
mName = builder.mName;
22+
mDesc = builder.mDesc;
2223
}
2324

2425
/**
@@ -53,12 +54,20 @@ public String getName() {
5354
return mName;
5455
}
5556

57+
/**
58+
* @return the description
59+
*/
60+
public String getDesc() {
61+
return mDesc;
62+
}
63+
5664
public static abstract class Builder {
5765
private Double mLatitude;
5866
private Double mLongitude;
5967
private Double mElevation;
6068
private DateTime mTime;
6169
private String mName;
70+
private String mDesc;
6271

6372
public Builder setLatitude(Double latitude) {
6473
mLatitude = latitude;
@@ -80,8 +89,13 @@ public Builder setTime(DateTime time) {
8089
return this;
8190
}
8291

83-
public Builder setName(String mName) {
84-
this.mName = mName;
92+
public Builder setName(String mame) {
93+
mName = mame;
94+
return this;
95+
}
96+
97+
public Builder setDesc(String desc) {
98+
mDesc = desc;
8599
return this;
86100
}
87101

parser/src/main/java/io/ticofab/androidgpxparser/parser/domain/Route.java

+14-14
Original file line numberDiff line numberDiff line change
@@ -72,38 +72,38 @@ public Builder setRoutePoints(List<RoutePoint> routePoints) {
7272
return this;
7373
}
7474

75-
public Builder setRouteName(String mRouteName) {
76-
this.mRouteName = mRouteName;
75+
public Builder setRouteName(String routeName) {
76+
mRouteName = routeName;
7777
return this;
7878
}
7979

80-
public Builder setRouteDesc(String mRouteDesc) {
81-
this.mRouteDesc = mRouteDesc;
80+
public Builder setRouteDesc(String routeDesc) {
81+
mRouteDesc = routeDesc;
8282
return this;
8383
}
8484

85-
public Builder setRouteCmt(String mRouteCmt) {
86-
this.mRouteCmt = mRouteCmt;
85+
public Builder setRouteCmt(String routeCmt) {
86+
mRouteCmt = routeCmt;
8787
return this;
8888
}
8989

90-
public Builder setRouteSrc(String mRouteSrc) {
91-
this.mRouteSrc = mRouteSrc;
90+
public Builder setRouteSrc(String routeSrc) {
91+
mRouteSrc = routeSrc;
9292
return this;
9393
}
9494

95-
public Builder setRouteNumber(Integer mRouteNumber) {
96-
this.mRouteNumber = mRouteNumber;
95+
public Builder setRouteNumber(Integer routeNumber) {
96+
mRouteNumber = routeNumber;
9797
return this;
9898
}
9999

100-
public Builder setRouteLink(Link mRouteLink) {
101-
this.mRouteLink = mRouteLink;
100+
public Builder setRouteLink(Link routeLink) {
101+
mRouteLink = routeLink;
102102
return this;
103103
}
104104

105-
public Builder setRouteType(String mRouteType) {
106-
this.mRouteType = mRouteType;
105+
public Builder setRouteType(String routeType) {
106+
mRouteType = routeType;
107107
return this;
108108
}
109109

0 commit comments

Comments
 (0)