Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Termynal size, update first steps, add fast button #6

Merged
merged 2 commits into from
Dec 26, 2019

Conversation

tiangolo
Copy link
Member

Fix Termynal containers size, make it discover and fix the container size before animating it to avoid growing containers that end up changing the size of the page and make it move if the user scrolls to the bottom.

Add a "fast" button to Termynals to allow skipping the animation.

Use Termynal for First Steps.

@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   41.17%   41.17%           
=======================================
  Files           7        7           
  Lines         391      391           
=======================================
  Hits          161      161           
  Misses        230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91c5a4...941e86d. Read the comment docs.

@tiangolo tiangolo merged commit 234e50a into master Dec 26, 2019
@tiangolo tiangolo deleted the fix-termynal-size branch December 26, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants