Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix broken link to newsletter sign-up in docs/help.md #84

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

mborus
Copy link
Contributor

@mborus mborus commented Sep 7, 2021

Trying to subscribe to the newletter by clicking on https://sqlmodel.tiangolo.com/newsletter/ gives a 404 error,

Maybe change URL to https://fastapi.tiangolo.com/newsletter/ to make it work?

Trying to subscribe to the newletter by clicking on https://sqlmodel.tiangolo.com/newsletter/ gives a 404 error, 

Maybe change URL to https://fastapi.tiangolo.com/newsletter/ to make it work?
docs/help.md Outdated Show resolved Hide resolved
@tiangolo tiangolo changed the title Fix broken link to newsletter sign-up ✏ Fix broken link to newsletter sign-up Aug 27, 2022
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #84 (937d3b2) into main (9664c88) will not change coverage.
The diff coverage is n/a.

❗ Current head 937d3b2 differs from pull request most recent head 9ef4154. Consider uploading reports for the commit 9ef4154 to get more accurate results

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         182      182           
  Lines        6054     6054           
=======================================
  Hits         5908     5908           
  Misses        146      146           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tiangolo tiangolo changed the title ✏ Fix broken link to newsletter sign-up ✏ Fix broken link to newsletter sign-up in docs/help.md Aug 27, 2022
@tiangolo
Copy link
Member

Good catch, thank you! 🤓

@tiangolo tiangolo enabled auto-merge (squash) August 27, 2022 20:30
@tiangolo tiangolo merged commit 31beaf1 into fastapi:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants