🐛 Fix enum type checks ordering in get_sqlalchemy_type
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enum subclassing/mix-in[1] is used, especially to ensure compatibility and produce correct OpenAPI specifications with FastAPI[2], SQLModel on its side doesn't map to the correct SQLAlchemy type. e.g.: * `class Foo(Enum)` will work but won't allow a proper OpenAPI spec. to be generated. * `class Foo(str, Enum)` will fix the previous situation, but prevents SQLModel to read and map the object from the DB (due to validation errors). Changing ordering of checks to ensure that Enum subclasses are tested first. [1] https://docs.python.org/3/library/enum.html#restricted-enum-subclassing [2] https://fastapi.tiangolo.com/sq/tutorial/path-params/#create-an-enum-class
|
This will be available in the next release, |
8 tasks
1 task
9 tasks
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix enum type checks ordering in
get_sqlalchemy_typeThis continues the work in #442 by @pierrecdn as I can't push to the original branch, but it includes his commits. 🤓