Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix handling validators for non-default values #253

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

byrman
Copy link
Contributor

@byrman byrman commented Feb 26, 2022

@tiangolo tiangolo changed the title 🐛 Fix issue 230 🐛 Fix handling validators for non-default values Aug 27, 2022
@tiangolo
Copy link
Member

tiangolo commented Aug 27, 2022

Awesome, thanks for writing the tests for it too! 🍰 ☕

This fix will be available in the next version, SQLModel 0.0.7, released in the next hours. 🎉

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #253 (2829a4c) into main (71d6fcc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   97.69%   97.70%           
=======================================
  Files         184      185    +1     
  Lines        6117     6134   +17     
=======================================
+ Hits         5976     5993   +17     
  Misses        141      141           
Impacted Files Coverage Δ
sqlmodel/main.py 84.59% <100.00%> (ø)
tests/test_validation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tiangolo tiangolo enabled auto-merge (squash) August 27, 2022 23:09
@tiangolo tiangolo merged commit d380736 into fastapi:main Aug 27, 2022
@byrman byrman deleted the byrman_fix-issue-230 branch August 31, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants