🐛 Fix Select and SelectOfScalar to inherit cache to avoid warning: SAWarning: Class SelectOfScalar will not make use of SQL compilation caching
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool 👌🏼 |
|
This patch looks good to me. |
|
Noticed this as well, would be nice to get rid of the warning spam. LGTM |
oldfielj-ansto
approved these changes
Apr 19, 2022
leynier
approved these changes
Apr 19, 2022
tiangolo
changed the title
Select and SelectOfScalar to inherit cacheSelect and SelectOfScalar to inherit cache to avoid warning: SAWarning: Class SelectOfScalar will not make use of SQL compilation caching
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 185 185
Lines 6134 6134
=======================================
Hits 5993 5993
Misses 141 141 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Awesome! Thanks a lot @rabinadk1 and @leynier for the tip! 🍰 ☕ This will be available in SQLModel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #189
Original Solution found in #189 (comment) from @leynier