-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆ Bump Starlette to version 0.22.0
to fix bad encoding for query parameters in TestClient
#5659
⬆ Bump Starlette to version 0.22.0
to fix bad encoding for query parameters in TestClient
#5659
Conversation
📝 Docs preview for commit d42a417 at: https://6377916021146403d9d10c6f--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
And thanks for the test too :)
This will be great for the fix on GZipMiddleware too! |
Thank you @azogue ! I spent forever tracking back a broken test to this issue ! Is there something missing for this PR to be merged ? |
@lovasoa, I don't know :( If there is, I could do it if pointed to 🥺 Release notes are filled with GH Actions, I think, and there is no 'milestone' tracking to add it for the next patch I suppose it will be merged soon 🤞 We are using fastAPI in production with 0.85.1, waiting for the fix to update it, after adapting the test suite with the TestClient change. The only thing I would do different is to unpin the |
0.22.0
to fix bad encoding for query parameters in TestClient
@azogue I would be in favor of that too, but you know that means |
Update
starlette
to v0.22.0 to fix issue withTestClient
doing an extraunquote
in the URL query(encode/starlette#1952 and encode/starlette#1953), introduced with the (tests)-Breaking change in v0.21.0 with the swap from
requests.Session
tohttpx.Client
for theTestClient
closes #5646