Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Upgrade internal testing dependencies: mypy to version 0.910, add newly needed type packages #3350

Merged
merged 8 commits into from
Oct 5, 2021

Conversation

ArcLightSlavik
Copy link
Contributor

@ArcLightSlavik ArcLightSlavik commented Jun 9, 2021

Mypy has released a new version which includes a new nice features.

This PR includes:

  1. Update mypy dependency to 0.901 from 0.812
  2. Addition of 'types' dependencies due to update to Typeshed (http://mypy-lang.blogspot.com/2021/05/the-upcoming-switch-to-modular-typeshed.html)
  3. Removal of mypy.ini and inclusion of it inside of pyproject.toml.

Edit (by @tiangolo): I upgraded mypy and the new stubs to their current latest. I also added types-dataclasses that is needed for Python 3.6.

@Mause
Copy link
Contributor

Mause commented Jul 4, 2021

Should probably update this to 0.910 now?

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3350 (c6dd0f5) into master (189ac3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3350   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          410       410           
  Lines        10281     10281           
=========================================
  Hits         10281     10281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189ac3e...c6dd0f5. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

📝 Docs preview for commit 9a2b6dc at: https://615c0cdd729c83e4da89f680--fastapi.netlify.app

@tiangolo
Copy link
Member

tiangolo commented Oct 5, 2021

Awesome, thanks @ArcLightSlavik! 😎 🍰

And thanks @Mause for the comment. Yep, I upgraded mypy and the new stubs to their current latest. I also added types-dataclasses that is needed for Python 3.6.

This is included in FastAPI 0.68.3, just released. 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

📝 Docs preview for commit c6dd0f5 at: https://615c0ec86b69c1b256a958c5--fastapi.netlify.app

@tiangolo tiangolo changed the title Upgrade mypy to version 0.901 ⬆ Upgrade internal testing dependencies: mypy to version 0.910, add newly needed type packages Oct 5, 2021
@tiangolo tiangolo merged commit 8c10281 into fastapi:master Oct 5, 2021
@ArcLightSlavik
Copy link
Contributor Author

Opps completely forgot to update this 🙈
Thanks @tiangolo !

@ArcLightSlavik ArcLightSlavik deleted the mypy_900 branch October 5, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants