-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Bump Uvicorn max range to 0.15.0 #3345
Conversation
awesome, thanks guys! |
I have no influence over the FastAPI project, but:
|
Thanks for the review @musicinmybrain :) |
📝 Docs preview for commit 9c0c080 at: https://613c6127c187a655d8a62524--fastapi.netlify.app |
Great, thanks @Kludex! 🍰 For now, I would prefer not to add a dependency on Thanks everyone else for the comments too! ☕ This is included in FastAPI |
The thing is that Starlette is too generic on its ASGI types, and uvicorn is strict now. In any case, FastAPI shouldn't care about asgiref, I'm going to take care on Starlette. |
Woohoo! Nice 🎉 😎 🤓 |
EDIT: We probably want to add
asgiref
as dependency and use its types.