fix: allow ESM preset to be used in monorepo structure #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add an example repo to the |
|
@ahnpnl does the example mean monorepo workspace, right? Is the name |
|
Yes a monorepo project, that name LGTM |
ahnpnl
requested changes
Jun 2, 2021
| @@ -0,0 +1,27 @@ | |||
| # ExampleAppV12Monorepo | |||
There was a problem hiding this comment.
Would you please copy the README from example-app-v12?
| "@angular-devkit/build-angular": "~12.0.2", | ||
| "@angular/cli": "~12.0.2", | ||
| "@angular/compiler-cli": "~12.0.2", | ||
| "@types/jasmine": "~3.6.0", |
| "compilerOptions": { | ||
| "outDir": "../../out-tsc/spec", | ||
| "types": [ | ||
| "jasmine" |
| ] | ||
| }, | ||
| "files": [ | ||
| "src/test.ts", |
|
lint needs fixing with |
ahnpnl
reviewed
Jun 2, 2021
| "build": "ng build", | ||
| "watch": "ng build --watch --configuration development", | ||
| "test": "jest -c=projects/app1/jest.config.js", | ||
| "test-esm": "NODE_OPTIONS=--experimental-vm-modules jest -c=projects/app1/jest-esm.config.js" |
There was a problem hiding this comment.
sadly Windows is not happy with NODE_OPTIONS, this option seems to work only with Linux/Mac
|
Thank you for your repeatedly kindly reviews. |
ahnpnl
approved these changes
Jun 2, 2021
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because
<rootDir>is not workspace-root directory when it has a monorepo structure like Nrwl/Nx,<rootDir>/node_modulesis not compatible with that.Test plan
Does this PR introduce a breaking change?
If the workspace is not monorepo and
jest.config.jsis placed at the root directory, the result is not changed. This should help issues at monorepo.Other information