feat: support jest 26 #374
Conversation
| "testEnvironment": "jest-environment-jsdom-sixteen" | ||
| } | ||
| ``` | ||
| **Jest** v26 by default uses **JSDOM** 16 to support Node 10+. |
There was a problem hiding this comment.
Is JSDOM 16 compatible with Jest 25 ? I'm not sure what to write here. Any thoughts ?
There was a problem hiding this comment.
It should be. But in 99% of the cases, whoever uses Jest v26 will be happy to use JSDOMv16 and Nodev10.
JSDOM is not a interesting test-target like IE11 or Edge, so a specific setup will not be wanted by 99% of jest users.
I think we can remove that "should also be compatible" part like you did 👍
There was a problem hiding this comment.
jest-environment-jsdom-sixteen et. al. are compatible with any version of Jest. Knowing jsdom project, they'll drop Node 10 way earlier than Jest does, so this section may still be handy. You could provide references to specific tags, so people on lower versions can refer to
There was a problem hiding this comment.
I brought back the part for providing references to specific tags as suggestion :)
| "testEnvironment": "jest-environment-jsdom-sixteen" | ||
| } | ||
| ``` | ||
| **Jest** v26 by default uses **JSDOM** 16 to support Node 10+. |
There was a problem hiding this comment.
It should be. But in 99% of the cases, whoever uses Jest v26 will be happy to use JSDOMv16 and Nodev10.
JSDOM is not a interesting test-target like IE11 or Edge, so a specific setup will not be wanted by 99% of jest users.
I think we can remove that "should also be compatible" part like you did 👍
|
shall I merge this ? |
|
Let's do it |
|
When to expect a release? |
|
Can this PR be added to a new release ? |
|
Was released in 8.2.1. |
Close #367