Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released version does not support TypeScript 2.8.4 #320

Closed
carnegie-jwilliamson opened this issue Oct 4, 2019 · 4 comments
Closed

Released version does not support TypeScript 2.8.4 #320

carnegie-jwilliamson opened this issue Oct 4, 2019 · 4 comments

Comments

@carnegie-jwilliamson
Copy link

We have an Ionic 3 project that is not supported by TypeScript v2.9 or newer. jest-preset-angular v7.1.1 does not work with older versions of TypeScript, so we can't use it right now, and we try to avoid using unreleased versions.

Can you release a new version that includes the fix for older TypeScript compilers (#261 )?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Oct 4, 2019

Hi,

Actually your request is related to ts-jest dependency we have in this preset. 7.0.0+ uses ts-jest 23.10.x which is a breaking change. < 7.0.0 ts-jest doesn't support to use AST transformers. I don't think it's possible to fulfil your needs.

@carnegie-jwilliamson
Copy link
Author

Maybe I've misdiagnosed the problem, but if I use jest-preset-angular=7.1.1, my tests fail to build with TypeError: ts.createStringLiteral is not a function. If I update jest-preset-angular to use the latest master then the tests build fine.

@wtho
Copy link
Collaborator

wtho commented Oct 15, 2019

Yeah, this is already solved, but not published yet (#272).

If you don't mind I will close this issue, the new version will be published soon.

@wtho wtho closed this as completed Oct 15, 2019
@carnegie-jwilliamson
Copy link
Author

Thanks. Looking forward to the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants