Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-js v2 not listed as dependency, but imported in setupJest.js #244

Closed
wtho opened this issue Mar 21, 2019 · 4 comments
Closed

core-js v2 not listed as dependency, but imported in setupJest.js #244

wtho opened this issue Mar 21, 2019 · 4 comments

Comments

@wtho
Copy link
Collaborator

wtho commented Mar 21, 2019

Some days ago core-js v3 was released and changed its library structure.

jest-preaet-angular imports core-js in setupJest.ts, without specifying the version anywhere.

This leads to confusion as more projects update to v3 and the old interface is not available anymore.

I think we should specify the core-js version at least as peerDependency, so that npm can warn the developer when core-js v2 is not available.

@lonix1
Copy link

lonix1 commented Mar 21, 2019

Yes this would be a great help! It was so confusing because the errors I was getting did not help to trace the problem.

@thymikee
Copy link
Owner

Feel free to make it a peer dep :)

@skorunka
Copy link

skorunka commented Jan 4, 2020

What helped me was to add "jest-preset-angular": "7.1.0",(just latest) to devDependencies and yarn(npm i).

@wtho
Copy link
Collaborator Author

wtho commented Jan 20, 2020

@skorunka Yeah, it was released in 7.1.0, but should also be solved when using a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants