-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rxjs from imports #17
Comments
For lots of folks it would be a breaking change, so I'd publish it as v1. cc: @Meligy |
As someone who got bitten by inclusion of RxJS, I'd really say please do not include it. It should show an error, which tells people that they are missing something. Since this project is meant for the Angular CLI, I'd suggest it should be as close as possible to what it puts in Only add stuff that is required to get jest running, and if possible, try to use the |
And, on another side, something that I have not mentioned but really should have: This project is SUPER AWESOME, and does make what seemed a very tough job become super nice. Thanks heaps. |
Yeah, so we can't really use |
As stated here: angular/angular-cli#4543 (comment).
It shouldn't be auto included. Although need to add a guide on some useful imports like:
The text was updated successfully, but these errors were encountered: