Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host bindings in the snapshot #125

Closed
yurii-sorokin opened this issue Feb 20, 2018 · 7 comments
Closed

Host bindings in the snapshot #125

yurii-sorokin opened this issue Feb 20, 2018 · 7 comments

Comments

@yurii-sorokin
Copy link
Contributor

Hi. Is there any plan to add attributes (classes, styles) added by @HostBinding to the snapshot?

@thymikee
Copy link
Owner

No plans, but feel free to take a stab on it :)

@yurii-sorokin
Copy link
Contributor Author

Ok. I decided to create serializer as a separate package. It slightly different from serializer in this repo. It relies on debugNodes + existing react serializer. It's not stress tested yet, but you could take a look.

@thymikee
Copy link
Owner

Share it :)

@yurii-sorokin
Copy link
Contributor Author

Oops, 🤦‍♂️. The package on github or on npm.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Feb 22, 2018

I like that you use serialize which is available since jest 21 👍

@yurii-sorokin
Copy link
Contributor Author

Also, as my serializer will break all existing tests (till the snapshot update of course), I have moved setup of serializers to jest config (PR #126). Now it would be possible to play with my serializer with this preset untouched.

@yurii-sorokin
Copy link
Contributor Author

yurii-sorokin commented Feb 22, 2018

I guess the issue could be closed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants