Redo not working when editing query parameters

[moltob]

Describe the bug
When editing a request's query parameter's value, the redo hotkey (ctrl-y) is not working but instead performs an undo.

To Reproduce

1. Open query parameters view of a request.
2. Add a new query parameter
3. Type some text into the value field
4. Hit "CTRL-Z" once or twice to undo (works)
5. Hit "CTRL-Y" a few times to redo (does not work, but still does undo)

Expected behavior
CTRL-Y performs a redo operation.

Platform:

• OS: Windows (WSL), German keyboard layout
• vscode version: 1.95.1
• node version: 21.7.3
• extension version: 2.29.6

Are you using the free version/paid version/trial:
Paid.

[rangav]

Hi @moltob thanks for reporting the issue.

can you please confirm your subscription using below form
https://www.thunderclient.com/verify

[moltob]

Done

[rangav]

Thanks for the confirmation. I wiill verify and fix it asap.

[rangav]

redo keyboard shortcut is ctrl + Shft + Z

[moltob]

Is that just a comment or the supposed solution?

The "redo" shortcut in most applications is CTRL-Y. The mentioned CTRL-SHIFT-Z is an alternative sometimes found in applications (I read Photoshop). Windows therefore binds both shortcuts to "redo" automatically.

Regardless of that, my VSCode shortcuts choose to take over the system settings, meaning CTRL-Y is still an active "redo" shortcut:

Why would an extension choose to change that? And in fact make it even worse and bind "undo" to CTRL-Y as well?

[rangav]

We did not change anything to keybindings

We implemented standard keybindings for undo and redo

See vscode keyboard shortcuts

[moltob]

It is not up to the extension to decide on bindings:

[rangav]

Did you change to keybindings for redo?

[moltob]

No, as I wrote above, this is Windows default.

[rangav]

Thanks for the clarification, I will look into the issue.

[rangav]

This bug is fixed in v2.32.9, Please test it and let me know your feedback.

https://github.com/thunderclient/thunder-client-support/releases/tag/v2.32.9