Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sent” folder: Missing space between "To" and address #8170

Closed
2 tasks done
AS98765 opened this issue Sep 25, 2024 · 3 comments · Fixed by #8259
Closed
2 tasks done

"Sent” folder: Missing space between "To" and address #8170

AS98765 opened this issue Sep 25, 2024 · 3 comments · Fixed by #8259
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors

Comments

@AS98765
Copy link

AS98765 commented Sep 25, 2024

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App version

6.804

Where did you get the app from?

None

Android version

GrapheneOS

Device model

No response

Steps to reproduce

Imo not necessary.

Expected behavior

Space.

Actual behavior

Missing space.

Screenshot 2024-09-25 143623 - ss

Logs

No response

@AS98765 AS98765 added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Sep 25, 2024
@kewisch kewisch added good first issue Ideal for newcomers to start contributing and removed unconfirmed Newly reported issues awaiting triage or confirmation labels Oct 1, 2024
@kewisch
Copy link
Member

kewisch commented Oct 1, 2024

Thanks for reporting, can confirm. This should be a super easy fix if all goes well, would you be interested in looking into it?

@kewisch kewisch added the status: needs information Needs more information to proceed label Oct 1, 2024
@github-actions github-actions bot removed the status: needs information Needs more information to proceed label Oct 1, 2024
@alvar0liveira
Copy link

Hey!

I'm interested in contributing to this issue.

I already found a solution but I don't if a good way to solve it.

I changed the getRecipientDisplayNames in MessageHelper.kt in line 37 to append a whitespace before append the recipients list.

Also I saw that you don't have unit tests for this method, if you agree I can write some

Hope to get your feedback.

Thanks!

@kewisch
Copy link
Member

kewisch commented Oct 7, 2024

@alvar0liveira I'm excited you're ready to contribute! Why don't you go ahead and send a pull request with what you have? The team will take a look and review. Unit tests would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants