Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mark all as read" in search results acts on current folder #1194

Open
0xf10e opened this issue Mar 21, 2016 · 7 comments
Open

"Mark all as read" in search results acts on current folder #1194

0xf10e opened this issue Mar 21, 2016 · 7 comments
Labels
type: enhancement New features or improvements to existing features.

Comments

@0xf10e
Copy link

0xf10e commented Mar 21, 2016

This one is really annoying:
When I search for something and get the results I can hit "Select all" and only the search results get selected.
But when I hit (almost always accidentally) "Mark all as read" the whole folder currently shown gets marked as read.

So while I was sorting my email on my tablet a few minutes ago all my inbox got marked as read…

@philipwhiuk philipwhiuk added the type: bug Something is causing incorrect behavior or errors label Mar 21, 2016
@philipwhiuk
Copy link
Contributor

The button is technically correct here ('all' means 'all' not 'what I can currently see') but it's not very intuitive.

@0xf10e
Copy link
Author

0xf10e commented Mar 22, 2016 via email

@0xf10e
Copy link
Author

0xf10e commented Mar 22, 2016 via email

@philipwhiuk
Copy link
Contributor

I did say it was wrong :)

I think the fix is to handle search results differently and pass along the list of messages/threads/UUIDs.

I don't think a confirmation dialog is a good idea.

@cketti
Copy link
Member

cketti commented Mar 23, 2016

Actions that affect the whole folder should probably live elsewhere. Let's call this an enhancement and deal with it during the design overhaul.

@cketti cketti added type: enhancement New features or improvements to existing features. and removed type: bug Something is causing incorrect behavior or errors labels Mar 23, 2016
@cketti cketti added this to the Design Overhaul milestone Mar 23, 2016
@vladimir-mencl-eresearch

Can I add a +1 on this issue? I got caught by the same thing - used Mark All As Read in search results and all my inbox got marked as read. Turned out to be rather upsetting.

I would consider this a bug: having a button shown in Search Results but acting on the whole folder.

I am happy to wait for an enhancement to have an action that marks all messages in the search results as read.

But until it is implemented, can we please have the Mark All As Read item removed from the menu shown in the Search Results? It is confusing and I would not want more users to fall into the same trap as I did myself (and so did @0xf10e )

Cheers,
Vlad

@groszdaniel
Copy link

Just got hit by this. There's a confirmation dialog now, but it just asks something like "Do you want to mark all messages read?", and doesn't make what "all" refers to any clearer. I concur with the original request as well as with that this should be considered a bug, and a major one that can cause unexpected information loss at that, and if it's not changed to the more useful behavior, at least the confirmation dialog should be changed to specify that all mail in the current folder will be marked read, not just the search results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

5 participants