Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase native feel on iOS #1666

Open
slrgt opened this issue Jan 21, 2025 · 2 comments
Open

Increase native feel on iOS #1666

slrgt opened this issue Jan 21, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@slrgt
Copy link

slrgt commented Jan 21, 2025

Is Your Feature Request Related to a Problem?

While using the app on an iPhone it's pretty clear it was designed for android first. For example the bottom bar has a lot of empty space on ios, the very rounded squares and pill shaped accents all make it really standout and not feel native.

Here's the Thunder app and the Voyager app to see the difference especially the large empty space in the bottom and top bar

Image

the red is where Thunder bars are and the blue is where the Voyager bars are both screenshots taken on the same device

Feature Description

for iOS I propose having some default tweaks to the theme so it feels more native to the platform:

  • adjust the empty space under and above the buttons on the bottom and top bar
  • remove the pilled accents on the buttons in the bottom bar
  • make the rounded square around the FAB into a circle

Alternative Solutions

No response

Additional Context

No response

@slrgt slrgt added the enhancement New feature or request label Jan 21, 2025
@micahmo
Copy link
Member

micahmo commented Jan 21, 2025

Just FYI, the app was designed using Material Design 3 guidelines (https://m3.material.io/) which are not specific to Android but are designed to be cross-platform across Android, iOS, Windows, Mac, and web. It's not necessarily the most common design pattern for iOS yet, but it's picking up steam, especially on the web. And it provides a consistent UI across platforms if you are someone who uses Thunder on different devices.

It's obviously up to @hjiangsu if he would ever want to add more iOS-specific styling, but his primary OS is iOS and he has kept the default material theming pretty consistently. 😊

@hjiangsu
Copy link
Member

I'd like to chime in on this issue - as @micahmo has mentioned, Thunder's UI is generally based on Material 3 guidelines (and as such, it might feel like it is an Android-first design since the Material 3 spec was developed by Google).

The main reason why Thunder currently sticks with the Material 3 guidelines is simply due to the fact that our underlying framework (Flutter, which allows cross-platform integration with iOS, Android, and desktop) has a more mature set of Material components than its iOS counterpart (Cupertino components)

While I would like to explore the option of having two different design patterns (e.g., Apple HIG and Material 3 that can be switched within the settings for example), the amount of effort required to maintain and conform to two different design patterns is too high for the number of contributors we have in the project right now.

I'll gladly keep this issue open as a possibility in the long term future, but I would like to wait until the iOS component library for Flutter is more mature and wait until we have more time (or more contributors helping with Thunder). I hope this clears things up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants