-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support Gym 0.26.0 #748
Conversation
…db, fixed formatting, fixed type hints, allow preprocessing_fn with truncated and terminated arguments, updated docstrings
|
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
- Coverage 93.42% 90.66% -2.76%
==========================================
Files 72 70 -2
Lines 4895 4917 +22
==========================================
- Hits 4573 4458 -115
- Misses 322 459 +137
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @Markus28 , I adjust GPU test to gym==0.25.2, but it seems some of the tests are failed to pass. Could you please fix those? |
Thanks! I think the issue was caused by |
* Changes to support Gym 0.26.0 * Replace map by simpler list comprehension * Use syntax that is compatible with python 3.7 * Format code * Fix environment seeding in test environment, fix buffer_profile test * Remove self.seed() from __init__ * Fix random number generation * Fix throughput tests * Fix tests * Removed done field from Buffer, fixed throughput test, turned off wandb, fixed formatting, fixed type hints, allow preprocessing_fn with truncated and terminated arguments, updated docstrings * fix lint * fix * fix import * fix * fix mypy * pytest --ignore='test/3rd_party' * Use correct step API in _SetAttrWrapper * Format * Fix mypy * Format * Fix pydocstyle.
Generally, I am trying to keep compatibility with Gym < 0.26.0 and envpool.
terminated
andtruncated
. Thedone
field does no longer have to be specified when data is added to the buffer.truncated
frominfo
and setterminated = done and not truncated
before adding the transition to the replay buffer.preprocess_fn
accepts eitherdone
orterminated
andtruncated
.terminated
This should not break any user code, unless the user is directly accessing the replay buffer. In particular, I didn't need to modify any of the training tests.