Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Allow a farmer to set a custom "extra" price on a node in the dashboard #499

Closed
DylanVerstraete opened this issue Jun 8, 2023 · 4 comments
Assignees
Labels
dashboard type_feature New feature or request
Milestone

Comments

@DylanVerstraete
Copy link

To complete threefoldtech/home#1392 we need on chain a way to set an extra price. But we also need a flow in the dashboard for a farmer to set a custom price.

I would suggest adding the new "button" on the farmer's node overview page where a modal opens so he can view/set an extra price.

A call to tfchain smartContractModule.setDedicatedNodeExtraFee must be mode with (node_id: u32, extra_fee: u64).

The extra_fee is expressed in mUSD (milli usd => USD * 1000)

Errors will be thrown when:

  • the node has active deployments
  • the node is rented already
@xmonader xmonader changed the title Allow a farmer to set a custom "extra" price on a node GPU: Allow a farmer to set a custom "extra" price on a node in the dashboard Jun 8, 2023
@xmonader xmonader added the type_feature New feature or request label Jun 8, 2023
@xmonader xmonader added this to the 2.1.0 milestone Jun 8, 2023
@AhmedHanafy725
Copy link
Contributor

for these errors, does it mean that the farmer can't set the extra fee if the node has node/rent contracts?

@DylanVerstraete
Copy link
Author

he farmer can't set the extra fee if the node has node/rent contracts

Yes indeed

@renauter
Copy link

See some specs from TFChain side here:
threefoldtech/tfchain#725

@A-Harby
Copy link
Contributor

A-Harby commented Jul 6, 2023

Verified.
image
image
image

@A-Harby A-Harby closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_feature New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants